FBX: Update ufbx to v0.14.0 #91528
Merged
FBX: Update ufbx to v0.14.0 #91528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bqqbarbhg
commented
May 3, 2024
bqqbarbhg
commented
May 3, 2024
|
Seems like there's three tasks remaining:
|
|
The dataset looked fine at a glance, didn't have the time to do a proper labeling this time. The only open issue is the Ready to merge by me. |
fire
approved these changes
May 6, 2024
|
I would not support blender pbr since it seems to not handle round tripping well? |
|
Disabled it for now in that case |
|
If it's ok can you rebase the pr so it's one commit? |
|
Could you amend in this documentation change too? diff --git a/thirdparty/README.md b/thirdparty/README.md
index 4a7ab7314a..8c07da5d24 100644
--- a/thirdparty/README.md
+++ b/thirdparty/README.md
@@ -894,7 +894,7 @@ number and run the script.
## ufbx
- Upstream: https://github.com/ufbx/ufbx
-- Version: git (v0.11.1, 2024)
+- Version: 0.14.0 (80ff790ab36507b99ec7e4ef55b9cfb076ce821b, 2024)
- License: MIT
Files extracted from upstream source: |
Sure, thanks! My bad for missing that one, should be fixed now. |
akien-mga
approved these changes
May 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to ufbx to version v0.14.0, which is currently being finished. I'm opening a draft PR to facilitate testing of the new version and so we can discuss a few of the newer features.
Some highlights of the ufbx updates up to v0.13.0:
Fixes from nearly complete v0.14.0, many based on Godot testing (#90986):
UFBX_INHERIT_MODE_HANDLING_COMPENSATE_NO_FALLBACKto fix some non-scaled inheritance casesTasks for me before I consider this safe for merging: